Skip to content

feat: add blas/ext/sorthp #8098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 22, 2025
Merged

feat: add blas/ext/sorthp #8098

merged 15 commits into from
Sep 22, 2025
+2,706 −0

Conversation

headlessNode
Copy link
Member

Resolves stdlib-js/metr-issue-tracker#77.

Description

What is the purpose of this pull request?

This pull request:

  • add blas/ext/sorthp

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@headlessNode headlessNode added the Feature Issue or pull request for adding a new feature. label Sep 18, 2025
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Sep 18, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Sep 18, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/sorthp $\color{red}443/444$
$\color{green}+99.77\%$ 		$\color{red}45/46$
$\color{green}+97.83\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{red}443/444$
$\color{green}+99.77\%$

The above coverage report was generated for the changes in this PR.

headlessNode
headlessNode commented Sep 18, 2025
View reviewed changes
headlessNode
headlessNode commented Sep 18, 2025
View reviewed changes
@headlessNode
fix: lint error
bc5197a 
Signed-off-by: Muhammad Haris <[email protected]>
@headlessNode headlessNode requested a review from kgryte September 18, 2025 18:26
kgryte
kgryte reviewed Sep 18, 2025
View reviewed changes
kgryte
kgryte reviewed Sep 18, 2025
View reviewed changes
kgryte
kgryte reviewed Sep 18, 2025
View reviewed changes
kgryte
kgryte reviewed Sep 18, 2025
View reviewed changes
@headlessNode
feat: add string support
1e52531 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@headlessNode headlessNode requested a review from kgryte September 20, 2025 11:17
kgryte
kgryte reviewed Sep 22, 2025
View reviewed changes
@kgryte
docs: update copy
7aaafed 
Signed-off-by: Athan <[email protected]>
kgryte
kgryte reviewed Sep 22, 2025
View reviewed changes
@kgryte
docs: update copy
f95f6f5 
Signed-off-by: Athan <[email protected]>
kgryte
kgryte reviewed Sep 22, 2025
View reviewed changes
@kgryte
docs: update copy
93f827d 
Signed-off-by: Athan <[email protected]>
kgryte
kgryte reviewed Sep 22, 2025
View reviewed changes
@kgryte
docs: update copy
ad7e601 
Signed-off-by: Athan <[email protected]>
kgryte
kgryte reviewed Sep 22, 2025
View reviewed changes
kgryte
kgryte reviewed Sep 22, 2025
View reviewed changes
@kgryte
docs: update copy
0d5f627 
Signed-off-by: Athan <[email protected]>
@kgryte kgryte self-requested a review September 22, 2025 00:40
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Sep 22, 2025
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 22, 2025
@kgryte
bench: avoid trivial sort
20dd427 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@kgryte
chore: clean-up
f46c1bd 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
kgryte
kgryte approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Sep 22, 2025
@kgryte kgryte merged commit bff3c1e into stdlib-js:develop Sep 22, 2025
14 checks passed
@headlessNode headlessNode deleted the ndarray-sorthp branch September 22, 2025 05:31
@headlessNode headlessNode mentioned this pull request Sep 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add blas/ext/sorthp

3 participants

@headlessNode @stdlib-bot @kgryte